Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality for historical data requests #4

Open
Big-Gray opened this issue Aug 28, 2023 · 3 comments
Open

Add functionality for historical data requests #4

Big-Gray opened this issue Aug 28, 2023 · 3 comments

Comments

@Big-Gray
Copy link

Currently pyairnow doesn't have functionality to make historical data requests. I'd like to add that.

@asymworks
Copy link
Owner

Sure, feel free to open a PR for it. I don't have any formal contributor guidelines at the moment, but please include tests, and try and keep coding somewhat consistent with what is in there.

@Big-Gray
Copy link
Author

Quick question: When I was running make test, I kept getting an error "Makefile:18: *** recipe commences before first target. Stop.". It seems that export is a make keyword, and if I make the following change it seems to work:

export :
poetry export -f requirements.txt -o requirements-dev.txt --with dev

exportar :
poetry export -f requirements.txt -o requirements-dev.txt --with dev

Have you run into this problem before when working on it?

@asymworks
Copy link
Owner

I haven't seen that issue on my end, but maybe different versions of make are more permissive with that keyword. I'll update the Makefile target to be requirements instead of export so it doesn't cause that problem anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants