Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] disable tracing by default for introspection queries or graphiql/playground #1093

Closed
frederikhors opened this issue Sep 29, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@frederikhors
Copy link
Contributor

frederikhors commented Sep 29, 2022

To reproduce:

  • git clone https://github.com/frederikhors/iss-async-graphql-error-handling && cd iss-async-graphql-error-handling && cargo run

  • Go to http://localhost:8000/graphiql

  • Look at the command line: a LOT of lines of tracing!

How to disable those lines? Are them because of GraphiQL or for introspection queries?

Can we disable by default?

I think #841 is for the same, right @nileshmali?

@frederikhors frederikhors added the enhancement New feature or request label Sep 29, 2022
@frederikhors
Copy link
Contributor Author

I think 13a66a5 fixes this. I'll try soon.

@frederikhors
Copy link
Contributor Author

It's printing only these lines now:

2022-10-01T09:21:51.985144Z  INFO async_graphql::graphql:84: close, time.busy: 3.12ms, time.idle: 14.6µs
  in async_graphql::graphql::parse
  in async_graphql::graphql::request

2022-10-01T09:21:51.987726Z  INFO async_graphql::graphql:108: close, time.busy: 2.44ms, time.idle: 15.4µs
  in async_graphql::graphql::validation
  in async_graphql::graphql::request

2022-10-01T09:21:52.011279Z  INFO async_graphql::graphql:137: close, time.busy: 23.2ms, time.idle: 16.2µs
  in async_graphql::graphql::field with path: __schema, parent_type: QueryRoot, return_type: __Schema!
  in async_graphql::graphql::execute
  in async_graphql::graphql::request

2022-10-01T09:21:52.011436Z  INFO async_graphql::graphql:122: close, time.busy: 23.5ms, time.idle: 17.1µs
  in async_graphql::graphql::execute
  in async_graphql::graphql::request

2022-10-01T09:21:52.011708Z  INFO async_graphql::graphql:56: close, time.busy: 29.8ms, time.idle: 19.3µs
  in async_graphql::graphql::request

So I think it works!

Thanks!

@nileshmali
Copy link

@frederikhors Yes, Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants