Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vague languages in TypeSystem #63

Closed
DataCorrupted opened this issue May 9, 2020 · 3 comments
Closed

Vague languages in TypeSystem #63

DataCorrupted opened this issue May 9, 2020 · 3 comments

Comments

@DataCorrupted
Copy link
Contributor

This issue is used to track vague languages when translating TypeSystem in Async-graphql Book.

@DataCorrupted
Copy link
Contributor Author

DataCorrupted commented May 9, 2020

"用Schema::data函数附加一个全局类型的数据"

  1. Schema::data or ContextBase::data? 我在documentation里没找到 Schema::data函数.
  2. "全局类型的数据" 如何理解? 如何和样例中给出的ctx.data::<DbPool>().take() 协调? 翻译成 "global typed data" 是否合适?

"并且你还能扩展标准的错误输出"

  1. 依照样例代码"扩展"被译作"extend" 是否合适?
  2. "错误输出" 还是 "错误信息"

InputObject

前后是否有空格不一致 (InputObject and Input Object), 暂时用没有空格的版本.

@sunli829
Copy link
Collaborator

"用Schema::data函数附加一个全局类型的数据"

  1. 应该是SchemaBuilder::data和Context::data函数。
  2. SchemaBuilder::data设置schema data, Context::data设置context data,是否可以这样翻译?

"并且你还能扩展标准的错误输出"

  1. 我认为合适。
  2. 错误信息吧。

"InputObject"

应该是无空格版本。


抱歉,中文文档写得很仓促,有很多疏漏。😁

@DataCorrupted
Copy link
Contributor Author

Thx, 我会稍作修改

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants