Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign in with Google. / Google OAuth API Infrastructure #515

Closed
reingoldkz opened this issue Jan 10, 2023 · 1 comment
Closed

Sign in with Google. / Google OAuth API Infrastructure #515

reingoldkz opened this issue Jan 10, 2023 · 1 comment
Assignees

Comments

@reingoldkz
Copy link

Hi async-labs team!

https://developers.google.com/identity/sign-in/web/sign-in

As we see from this google article, Google Sign in is deprecated and urging us to use new Sign in with Google.

My question:
if we doing builderbook project from scratch will the code work fine?
Is book content relevant at the moment?

Thanks for your job.

@klyburke klyburke assigned klyburke and tima101 and unassigned klyburke Jan 11, 2023
@tima101
Copy link
Member

tima101 commented Jan 11, 2023

@reingoldkz If I click on depreciated link inside the article you linked to, it says:

The deprecation applies only to web apps using the Google Sign-in JavaScript library. If your web pages currently load the Google Platform Library ([apis.google.com/js/platform.js](http://apis.google.com/js/platform.js)), you are affected and need to migrate to the newer Sign In With Google client library.

From: https://developers.googleblog.com/2021/08/gsi-jsweb-deprecation.html

Since passport, passport strategy and our code do not call /platform.js and do not use "Google Sign-in JavaScript library" - our codebase is not affected. Also see #458

@klyburke klyburke closed this as completed Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants