docs: updates to make styling consistent #36
Conversation
naman-tiwari
commented
May 25, 2022
naman-tiwari
commented
- Enhanced the readme file by adding emojis.
Naman patch 1
Merge branch 'asyncapi:master' into patch-1
Update README.md
naman-tiwari
requested review from
fmvilas,
mcturco,
magicmatatjahu and
asyncapi-bot-eve
as code owners
❌ Deploy Preview for enchanting-cascaron-aa83e8 failed.
|
README.md
Outdated
|
|
||
| ```cmd | ||
| npm install --save-dev | ||
| npm install --save-dev |
There was a problem hiding this comment.
Try to make good indents by adding two spaces before "`" signs and also change
npm install --save-dev
to the
npm install
added indents before npm commands and changed ```npm install --save-dev``` to ```npm install```
|
I have added indents before npm commands and changed |
|
I think my suggestions that I wrote in the other PR got lost. I think it was just suggesting to re-write some of the wording so it reads better. Are you able to see my review in the other PR and apply the changes here, @naman-tiwari? |
I will resolve the requested changes by today @mcturco . |
README.md
Outdated
|
|
||
| ```cmd | ||
| npm run storybook | ||
| ``` | ||
|
|
||
| - This will start your local Storybook environment on port `6006` by default. | ||
| - By default, this will launch your local Storybook environment on port '6006'. |
There was a problem hiding this comment.
| - By default, this will launch your local Storybook environment on port '6006'. | |
| - By default, this will launch your local Storybook environment on port `6006`. |
README.md
Outdated
|
|
||
| ```cmd | ||
| npm install | ||
| ``` | ||
|
|
||
| - Now, as you have all the `node_modules` installed in your project, you can start the Storybook environment. Run the command below to start it: | ||
| - Now that you've installed all of the 'node modules' in your project, you can launch the Storybook environment. To get started, type the command below: |
There was a problem hiding this comment.
| - Now that you've installed all of the 'node modules' in your project, you can launch the Storybook environment. To get started, type the command below: | |
| - Now that you've installed all of the `node modules` in your project, you can launch the Storybook environment. To get started, type the command below: |
reversed quotation marked on lines 13 and 19
|
@naman-tiwari Sorry for such a delay. As I see in the netlify logs you should remove |
|
This pull request has been automatically marked as stale because it has not had recent activity 😴 It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation. There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model. Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here. Thank you for your patience ❤️ |
|
/rtm |
|
I'm merging as the problem is not related to this PR anyway. |
|
Sorry it took that long @naman-tiwari. I just noticed it because the bot added the stale label. |
