Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[websocket] onError must not be called when status code is != 101 #110

Closed
jfarcand opened this issue May 15, 2012 · 1 comment
Closed

[websocket] onError must not be called when status code is != 101 #110

jfarcand opened this issue May 15, 2012 · 1 comment
Assignees
@jfarcand
Milestone
1.8.1

Comments

@jfarcand
Copy link
Contributor

Instead the onClose(code,status) must be called with code ==102 like Browser are doing.
@slandelle
Copy link
Contributor

@jfarcand Hey boss! What's the status of this?

jfarcand added a commit that referenced this issue Jan 23, 2014
@jfarcand
Fixes #110
40b4a90
@ghost ghost assigned jfarcand Jan 23, 2014
jfarcand added a commit that referenced this issue Jan 24, 2014
@jfarcand
Improve fixed for #110. Also fixes #156 by properly invoking the Asyn…
9f6ecee 
…cHandler/WebSocketListener
jfarcand added a commit that referenced this issue Jan 24, 2014
@jfarcand
Improve fixed for #110. Also fixes #156 by properly invoking the Asyn…
b64a2dc 
…cHandler/WebSocketListener
jfarcand added a commit that referenced this issue Jan 30, 2014
@jfarcand
Fixes #110
a3d4224
jfarcand added a commit that referenced this issue Jan 30, 2014
@jfarcand
Improve fixed for #110. Also fixes #156 by properly invoking the Asyn…
21a0fdf 
…cHandler/WebSocketListener
cs-workco pushed a commit to cs-workco/async-http-client that referenced this issue Apr 13, 2023
@artemredkin @weissi
cancel should be done with outbound user event (AsyncHttpClient#110)
54b0b96 
cancel should be done with outbound user event
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jfarcand jfarcand

Labels
None yet
Projects
None yet
Milestone
1.8.1
Development

No branches or pull requests
2 participants
@jfarcand @slandelle