Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated feed to utilize new standards, no longer presents unpublished posts #77

Merged
merged 1 commit into from Mar 10, 2015
Merged

Conversation

yanneves
Copy link
Member

Fixes #16

@larister
Copy link
Contributor

Great stuff, thanks @aaunel!

larister added a commit that referenced this pull request Mar 10, 2015
Updated feed to utilize new standards, no longer presents unpublished posts
@larister larister merged commit 2ad52b1 into asyncjs:master Mar 10, 2015
@aron
Copy link
Member

aron commented Mar 10, 2015

Hey, thanks for finally fixing this 😄 Looking at the code, other than showing 10 rather than 5 posts, I can't see any difference between the two loops. How does this handle unpublished posts differently?

@aron
Copy link
Member

aron commented Mar 10, 2015

Also small nitpick, but the path is at /feed/atom but the resource is now rss. I guess that's not a big deal if it keeps peoples readers up to date.

@yanneves
Copy link
Member Author

Hey @aron, yeah this was a bit of a headache to be honest! Changes were used from https://github.com/snaptortoise/jekyll-rss-feeds/blob/master/feed.xml.

The feed is Atom (atom:) and Dublin Core (dc:) compatible, I'd consider it an atom feed since it has some tags (like <link rel="enclosure />") and otherwise gracefully degrades to RSS or DC.. ? As for unpublished posts appearing, the previous version may have cached differently, I can confirm posts that were published-then-unpublished would stick around in the feed.

May also be worth noting that Issue #16 may still occur if the feed is cached by a third-party, like Google Feedburner.

@yanneves
Copy link
Member Author

Worth mentioning also, I made these changes on another Jekyll site to appear correctly in Feedly, following their (limited) docs on this http://feedly.uservoice.com/knowledgebase/topics/33323-publishers-optimize-your-feeds-for-feedly.

@yanneves yanneves deleted the gh-16 branch March 10, 2015 11:59
@aron
Copy link
Member

aron commented Mar 10, 2015

@aaunel ah okay, thats great thanks for the information!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RSS feed includes posts that have 'published: false'
3 participants