Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPRECATION WARNING: Passing a string to call() is deprecated and will be illegal in Sass 4.0. Use call(get-function("output-isolation")) instead. #248

Open
architarious opened this issue Jan 11, 2019 · 2 comments

Comments

@architarious
Copy link

architarious commented Jan 11, 2019

If you've upgraded to Sass 3.5.0 or higher you're likely getting this warning every time you try to compile something using the grid-span mixin. More information for why this warning exists is available in the Sass Changelog and in this article.

In order to get rid of it you need to wrap the function call with get-function().

Go to lines 58 through 64 on singulairtygs/_api.scss and change:

@if $Direction == 'both' or $From == 'left' or ($Direction == 'rtl' and $From == 'opposite') {
      $Left: call('output-#{$output-style}', map-merge($Span-Map, ('direction': left)));
    }
@if $Direction == 'both' or $From == 'right' or ($Direction == 'ltr' and $From == 'opposite') {
      $Right: call('output-#{$output-style}', map-merge($Span-Map, ('direction': right)));
 }

to

@if $Direction == 'both' or $From == 'left' or ($Direction == 'rtl' and $From == 'opposite') {
      $Left: call(get-function('output-#{$output-style}'), map-merge($Span-Map, ('direction': left)));
    }
 @if $Direction == 'both' or $From == 'right' or ($Direction == 'ltr' and $From == 'opposite') {
      $Right: call(get-function('output-#{$output-style}'), map-merge($Span-Map, ('direction': right)));
   }
@altrugon
Copy link

altrugon commented Apr 3, 2019

It seems like this project has been abandoned by its author, technology moves fast so it's understandable.

Here is my solution which will work on every npm install.

  1. Install patch-package.
    npm i patch-package
  2. Edit the singulairtygs/_api.scss as mentioned by @architarious on the description of this issue and save that file.
  3. Add the postinstall script to your package.json as followed:
"scripts": {
  "postinstall": "patch-package"
 }
  1. Create the patch by running the following command:
    npm run postinstall singularitygs
  2. Once the command has been finished you should have a patches folder, inside it is your patch.
  3. Since postinstall is an NPM script it will apply your patch after every npm install, the only thing left is add it to your repo and commit it.

If you need extra test before committing, delete node_modules and run npm install, then check the patch has been applied to the file.

@scottkellum
Copy link
Member

Keeping this open and locked so that others can see

@scottkellum scottkellum reopened this Jun 4, 2019
@at-import at-import locked as resolved and limited conversation to collaborators Jun 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants