Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don’t write styles by default #13

Closed
scottkellum opened this issue Jan 4, 2013 · 4 comments
Closed

Don’t write styles by default #13

scottkellum opened this issue Jan 4, 2013 · 4 comments

Comments

@scottkellum
Copy link
Member

Toolkit writes a far amount of CSS by default that can cause problems when importing it into existing projects. Would be nice if styles could be added with something like @import toolkit; @include toolkit; instead of just @import toolkit;.

@Snugug
Copy link
Member

Snugug commented Jan 4, 2013

When using @import 'toolkit'; you are importing all of Toolkit, including the partials designed to write styles. There are two partials that do so, the Border Box partial that adds *, *:before, *:after { @include box-sizing('border-box'); } and the Fluid Media partial that adds

img, video {
  max-width: 100%;
  height: auto;
}

I'm not going to create a mixin to write these styles as that's a bit much, but I'd be willing to consider not automatically importing the Border Box partial. My only concern is this is then a fairly large change that will break CSS using just the normal @import.

Are there other styles that are being written other than those two?

@scottkellum
Copy link
Member Author

I think thats it. Maybe we should break fluid media down so just the intrinsic ratio can be imported as needed?

@Snugug
Copy link
Member

Snugug commented Jan 4, 2013

I'm OK with splitting Fluid Media into Fluid Media and Intrinsic Ratio, as they are two different things.

On Friday, January 4, 2013 at 2:27 PM, Scott Kellum wrote:

I think thats it. Maybe we should break fluid media down so just the intrinsic ratio can be imported as needed?


Reply to this email directly or view it on GitHub (https://github.com/Snugug/toolkit/issues/13#issuecomment-11896103).

@Snugug
Copy link
Member

Snugug commented Jan 14, 2013

Spun Intrinsic Ratio into its own partial, updated gem accordingly.

@Snugug Snugug closed this as completed Jan 14, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants