Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't change broadcastMode in RichMedia #50

Closed
phix23 opened this issue Feb 14, 2019 · 5 comments
Closed

Can't change broadcastMode in RichMedia #50

phix23 opened this issue Feb 14, 2019 · 5 comments

Comments

@phix23
Copy link

phix23 commented Feb 14, 2019

The property broadcastMode in RichMedia.swift should be public so that it can be set from the application.
@nsagnett
Copy link
Contributor

You should use subclass and not directly RichMedia (Audio, LiveAudio, Video, LiveVideo, Medium, LiveMedium). In each subclass, broadcastMode is set with good value

@phix23
Copy link
Author

phix23 commented Feb 18, 2019

Thank you! However then this is inconsistent with the Android SDK. In RichMedia.java setBroadcastMode should be internal as well.

@nsagnett
Copy link
Contributor

You're right but it's not a problem though.

@nsagnett
Copy link
Contributor

It's ok for you ?

@phix23
Copy link
Author

phix23 commented Mar 19, 2019

My issue is resolved. Thank you!

@phix23 phix23 closed this as completed Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@phix23 @nsagnett