Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

At-modal property showClose=false not working #59

Open
andrzejkrawczyk opened this issue Nov 26, 2017 · 4 comments
Open

At-modal property showClose=false not working #59

andrzejkrawczyk opened this issue Nov 26, 2017 · 4 comments

Comments

@andrzejkrawczyk
Copy link

Customizable modal have a property showClose which have default value true. After passing value false is still showing cancel button.

Copied just example from the documentation.

Steps to reproduce

Which browser?

Google Chrome
"at-ui": "^1.3.0",
"at-ui-style": "^1.5.0",
"vue": "^2.5.8",
"vue-router": "^2.8.1",
"vuex": "^3.0.1"

What is expected?

After passing showClose=False, close button shouldn't be visible in modal

Best Regards,
Andrzej

@koppthe
Copy link
Member

koppthe commented Nov 27, 2017

i test with the code below, it works.

this.$Modal.alert({
      title: 'Here is Title',
      content: 'Here is Content',
      showClose: false,
      callback: function (action) {
          this.$Message(action)
      }
})

@andrzejkrawczyk
Copy link
Author

andrzejkrawczyk commented Nov 27, 2017

Hello,

Im using it in Vue2 in Vue components with vue loader in section and im using it like this:

                <at-button @click="modal1=true">Export game save</at-button>
                <at-modal 
                    v-model="modal1" 
                    title="Copy game state" 
                    :showClose="false">
                    <textarea wraps="hard" cols=50 rows=25 readonly>sdfsafdsarewqea</textarea>
                </at-modal>

@koppthe
Copy link
Member

koppthe commented Nov 27, 2017

use show-close in html

<at-modal
    v-model="modal1" 
    title="Copy game 
    :show-close="false">

@andrzejkrawczyk
Copy link
Author

It's not working. I checked the code for modal component, its having a attribute from data section "showCloseButton" but it's not props, so I can't inject a value to it from parent. That's why im not able to cover the cancel button. There should be added showCloseButton to props attribute as boolean

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants