New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix resampling failure of last particle #313
Conversation
[#790] PASSED on noeticTested on Alpine ROS [#790] PASSED on kineticAll tests passed
[#790] PASSED on melodicAll tests passed
|
@at-wat PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a comment, otherwise looks good.
{ | ||
1.0f, 2.0f, 3.0f, 4.0f, 4.0f | ||
}; | ||
testResample(probs, states, expected_resampled_states); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
[#791] PASSED on noeticTested on Alpine ROS [#791] PASSED on melodicAll tests passed
[#791] PASSED on kineticAll tests passed
|
Codecov Report
@@ Coverage Diff @@
## master #313 +/- ##
==========================================
- Coverage 94.51% 94.46% -0.06%
==========================================
Files 32 32
Lines 1642 1643 +1
==========================================
Hits 1552 1552
- Misses 90 91 +1
Continue to review full report at Codecov.
|
In the master branch, last particle is not removed even when its probability is small enough.
The algorithm described in Probabilistic Robotics is implemented.