Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added LoadPCD.srv #30

Merged
merged 2 commits into from
May 12, 2021
Merged

added LoadPCD.srv #30

merged 2 commits into from
May 12, 2021

Conversation

remco-r
Copy link
Contributor

@remco-r remco-r commented May 7, 2021

Service definition accompanies other pull request in mcl_3dl: at-wat/mcl_3dl#381

The map to localize in was previously loaded with a sensor_msgs::PointCloud2 topic. It was not guaranteed that the map was actually loaded with a single publish on the topic. Also it was overkill if you had a pcd you wanted to localize in, because you would have to convert it first to a PointCloud2, then publish it, and then it would be converted in mcl_3dl to a PCL cloud.

This service facilitates loading a pcd file by file path, directly into mcl_3dl.

@at-wat
Copy link
Owner

at-wat commented May 7, 2021

[33] PASSED on noetic

All tests passed
Summary: 0 tests, 0 errors, 0 failures, 0 skipped

@at-wat
Copy link
Owner

at-wat commented May 7, 2021

[33] PASSED on melodic

All tests passed
Summary: 0 tests, 0 errors, 0 failures, 0 skipped

@at-wat
Copy link
Owner

at-wat commented May 10, 2021

[34] PASSED on noetic

All tests passed
Summary: 0 tests, 0 errors, 0 failures, 0 skipped

[34] PASSED on melodic

All tests passed
Summary: 0 tests, 0 errors, 0 failures, 0 skipped

@at-wat
Copy link
Owner

at-wat commented May 11, 2021

[37] PASSED on melodic

All tests passed
Summary: 0 tests, 0 errors, 0 failures, 0 skipped

[37] PASSED on noetic

All tests passed
Summary: 0 tests, 0 errors, 0 failures, 0 skipped

Copy link
Owner

@at-wat at-wat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@at-wat at-wat merged commit ade255d into at-wat:master May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants