costmap_cspace: make Costmap3dLayerPlain and Costmap3dLayerOutput faster #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p3dLayerOutput::generateUpdateMsg() faster
[16] FAILED on melodicTest failed[16] FAILED on kineticTest failed[16] FAILED on noeticTest failed |
[17] PASSED on melodicAll tests passed[17] PASSED on kineticAll tests passed[17] PASSED on noeticAll tests passed |
Codecov Report
@@ Coverage Diff @@
## master #562 +/- ##
==========================================
+ Coverage 90.78% 90.84% +0.06%
==========================================
Files 58 58
Lines 4428 4447 +19
==========================================
+ Hits 4020 4040 +20
+ Misses 408 407 -1
Continue to review full report at Codecov.
|
f-fl0
reviewed
Nov 10, 2020
[18] PASSED on kineticAll tests passed[18] PASSED on melodicAll tests passed[18] PASSED on noeticAll tests passed |
[19] PASSED on melodicAll tests passed[19] PASSED on kineticAll tests passed[19] PASSED on noeticAll tests passed |
at-wat
reviewed
Nov 12, 2020
[20] PASSED on melodicAll tests passed[20] PASSED on kineticAll tests passed[20] FAILED on noeticTest failed[20] PASSED on melodicAll tests passed[20] PASSED on kineticAll tests passed[20] PASSED on noeticAll tests passed |
|
@at-wat I added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Costmap3dLayerPlain: As each map does not vary with its yaw angle, only first map is generated and copied to others.
Costmap3dLayerOutput: When an entire map is updated, all memories are copied at once. Otherwise, each raster is copied.