costmap_cspace: add costmap_3d_layers library #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
processMapOverlay now requires boolean arguement to toggle updateChainEntry().
This reverts commit 9289aca.
[388] PASSED on melodicAll tests passed[388] PASSED on noeticAll tests passed |
Codecov Report
@@ Coverage Diff @@
## master #688 +/- ##
=======================================
Coverage 90.96% 90.96%
=======================================
Files 61 61
Lines 4593 4593
=======================================
Hits 4178 4178
Misses 415 415 |
at-wat
reviewed
May 17, 2023
There was a problem hiding this comment.
Thank you for the PR.
Some general comments:
-
Please avoid changing white spaces unrelated to this PR.
If you think it's better to change the white spacing, please open another PR. -
Some of the code comments seem describing PR and not describing the code itself.
For example,Add somethingexplains something is added by this PR, but it's not very meaningful after it's been merged.
Please make sure code comments describes the code itself, and put comments describing the PR as PR description or self-review comments.
costmap_cspace/CMakeLists.txt
Outdated
|
|
||
| # Add library for costmap_3d_layers.cpp | ||
| add_library(costmap_3d_layers_lib src/costmap_3d_layers.cpp) |
There was a problem hiding this comment.
I think _lib is not very common for linux library file name and this will result lib/libcostmap_3d_layers_lib.so.
So, costmap_3d_layers would be better if there's no name conflict.
There was a problem hiding this comment.
Thank you for your suggestions. I will make changes and PR the corrections.
at-wat
reviewed
May 17, 2023
| @@ -346,7 +346,7 @@ class Costmap3dLayerBase | |||
| 0, 0, 0, map_->info.width, map_->info.height, map_->info.angle, | |||
| base_map->header.stamp)); | |||
| } | |||
| void processMapOverlay(const nav_msgs::OccupancyGrid::ConstPtr& msg) | |||
| void processMapOverlay(const nav_msgs::OccupancyGrid::ConstPtr& msg, const bool update_chain_entry) | |||
There was a problem hiding this comment.
Is it an intended change for this PR?
[390] FAILED on melodic
[390] FAILED on noetic
|
YuuchanShimi
commented
May 17, 2023
YuuchanShimi
force-pushed
the
add-cspace-library
branch
from
3898fc3
to
ed5f072
Compare
[389] PASSED on melodicAll tests passed[389] PASSED on noeticAll tests passed |
[393] PASSED on melodicAll tests passed[393] PASSED on noeticAll tests passed |
at-wat
reviewed
May 18, 2023
costmap_cspace/package.xml
Outdated
| @@ -24,6 +24,6 @@ | |||
|
|
|||
| <depend>costmap_cspace_msgs</depend> | |||
| <depend>neonavigation_common</depend> | |||
|
|
|||
[395] PASSED on melodicAll tests passed[395] PASSED on noeticAll tests passed |
at-wat
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.