Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trajectory_tracker_msgs: add path header in TrajectoryTrackerStatus #26

Merged
merged 2 commits into from Feb 21, 2020
Merged

trajectory_tracker_msgs: add path header in TrajectoryTrackerStatus #26

merged 2 commits into from Feb 21, 2020

Conversation

nhatao
Copy link
Collaborator

@nhatao nhatao commented Feb 21, 2020 •
edited

path_header stores the header of corresponding path.
This header includes exact timestamp of the path.
Stamp of path_header becomes 0 when no path has been received.

@at-wat
Copy link
Owner

at-wat commented Feb 21, 2020 •
edited

[#64] PASSED on kinetic

All tests passed 
build/test_results/trajectory_tracker_msgs/gtest-test_convert.xml: 4 tests
build/test_results/trajectory_tracker_msgs/roslint-trajectory_tracker_msgs.xml: 1 tests
Summary: 5 tests, 0 errors, 0 failures, 0 skipped

[#64] PASSED on melodic

All tests passed 
build/test_results/trajectory_tracker_msgs/gtest-test_convert.xml: 4 tests
build/test_results/trajectory_tracker_msgs/roslint-trajectory_tracker_msgs.xml: 1 tests
Summary: 5 tests, 0 errors, 0 failures, 0 skipped

@nhatao nhatao requested a review from at-wat February 21, 2020 04:01
@nhatao
Copy link
Collaborator Author

nhatao commented Feb 21, 2020

@at-wat PTAL.

at-wat
at-wat reviewed Feb 21, 2020
View reviewed changes
trajectory_tracker_msgs/msg/TrajectoryTrackerStatus.msg Outdated
@@ -7,4 +7,4 @@ Header header
float32 distance_remains
float32 angle_remains
int32 status

time path_stamp
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will we also want to add path_frame_id and path_seq?
seq may be useful to know that the trajectory_tracker received a new path message.
Storing as path_header might be an another option.

Copy link
Collaborator Author

@nhatao nhatao Feb 21, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to path_header.

@nhatao nhatao changed the title Add path timestamp in TrajectoryTrackerStatus Add path header in TrajectoryTrackerStatus Feb 21, 2020
@nhatao nhatao requested a review from at-wat February 21, 2020 05:45
@at-wat
Copy link
Owner

at-wat commented Feb 21, 2020 •
edited

[#65] PASSED on kinetic

All tests passed 
build/test_results/trajectory_tracker_msgs/gtest-test_convert.xml: 4 tests
build/test_results/trajectory_tracker_msgs/roslint-trajectory_tracker_msgs.xml: 1 tests
Summary: 5 tests, 0 errors, 0 failures, 0 skipped

[#65] PASSED on melodic

All tests passed 
build/test_results/trajectory_tracker_msgs/gtest-test_convert.xml: 4 tests
build/test_results/trajectory_tracker_msgs/roslint-trajectory_tracker_msgs.xml: 1 tests
Summary: 5 tests, 0 errors, 0 failures, 0 skipped

at-wat
at-wat approved these changes Feb 21, 2020
View reviewed changes
Copy link
Owner

@at-wat at-wat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@at-wat at-wat changed the title Add path header in TrajectoryTrackerStatus trajectory_tracker_msgs: add path header in TrajectoryTrackerStatus Feb 21, 2020
@at-wat at-wat merged commit 344fde0 into master Feb 21, 2020
@at-wat at-wat deleted the add-path-stamp-in-tracker-status branch February 21, 2020 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@at-wat at-wat at-wat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nhatao @at-wat