Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Clear All" Button added to clear applied Filters #562

Merged
merged 33 commits into from Oct 5, 2022

Conversation

mayukh551
Copy link
Contributor

@mayukh551 mayukh551 commented Sep 20, 2022

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

Added a "Clear All" button on the filter modal that clears all applied filters on react play

Fixes #551

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@vercel
Copy link

vercel bot commented Sep 20, 2022

@mayukh551 is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel.

@reactplay first needs to authorize it.

@vercel
Copy link

vercel bot commented Sep 20, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-play ✅ Ready (Inspect) Visit Preview Oct 5, 2022 at 9:41AM (UTC)

@atapas
Copy link
Member

atapas commented Sep 20, 2022

@mayukh551 Two quick observations

  • Can we make the Clear All a link than a button? It will bring a better UX I believe
  • When I click on the clear all, why does the background screen get refreshed? There may not be a functionality impact but the parent component shouldn't have impact. Can you please check?

src/common/modal/index.jsx Outdated Show resolved Hide resolved
src/common/modal/index.jsx Outdated Show resolved Hide resolved
src/common/search/FilterPlays.jsx Outdated Show resolved Hide resolved
src/common/search/FilterPlays.jsx Outdated Show resolved Hide resolved
src/common/search/FilterPlays.jsx Outdated Show resolved Hide resolved
src/common/search/FilterPlays.jsx Outdated Show resolved Hide resolved
joshi-kaushal
joshi-kaushal previously approved these changes Sep 28, 2022
src/common/search/FilterPlays.jsx Outdated Show resolved Hide resolved
@mayukh551
Copy link
Contributor Author

@joshi-kaushal
Done!

joshi-kaushal
joshi-kaushal previously approved these changes Sep 30, 2022
Copy link
Member

@Sachin-chaurasiya Sachin-chaurasiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments.

@mayukh551
Copy link
Contributor Author

@Sachin-chaurasiya Done!

@supminn
Copy link
Contributor

supminn commented Oct 2, 2022

Hi @mayukh551
I was going through your chain of commits for this PR on implementing clearAll feature.

I tried to come up with an easier solution -- click here

Let me know your thoughts on this.

cc @Sachin-chaurasiya @Angryman18

@atapas
Copy link
Member

atapas commented Oct 5, 2022

Hi @Angryman18

Can you please approve it if all good?

@Angryman18
Copy link
Member

Hi @mayukh551 I was going through your chain of commits for this PR on implementing clearAll feature.

I tried to come up with an easier solution -- click here

Let me know your thoughts on this.

cc @Sachin-chaurasiya @Angryman18

i have checked the PR as its not covering the edge case as mention #562 (comment)
so we are yet good to merge this for now i think and if you find more sorter way of handling the case apart from current changes please create a fresh issue and PR @supminn

Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The clear all filter works as expected. Thanks for adding this feature @mayukh551 . Approved.

@atapas atapas added hacktoberfest-accepted hacktoberfest-accepted and removed waiting for reviewers labels Oct 5, 2022
@atapas atapas merged commit aa7ed53 into reactplay:main Oct 5, 2022
@atapas
Copy link
Member

atapas commented Oct 5, 2022

@all-contributors please add @mayukh551 for Code

@allcontributors
Copy link
Contributor

@atapas

@mayukh551 already contributed before to code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ [Feature request]: Add a separate "Clear All filters" Button
6 participants