New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Clear All" Button added to clear applied Filters #562
Conversation
@mayukh551 is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel. @reactplay first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@mayukh551 Two quick observations
|
@joshi-kaushal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments.
@Sachin-chaurasiya Done! |
Hi @mayukh551 I tried to come up with an easier solution -- click here Let me know your thoughts on this. |
Hi @Angryman18 Can you please approve it if all good? |
i have checked the PR as its not covering the edge case as mention #562 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The clear all filter works as expected. Thanks for adding this feature @mayukh551 . Approved.
@all-contributors please add @mayukh551 for Code |
@mayukh551 already contributed before to code |
Description
Added a "Clear All" button on the filter modal that clears all applied filters on react play
Fixes #551
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Checklist: