Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Play Audio-Visualizer #851

Closed
wants to merge 10 commits into from
Closed

Add Play Audio-Visualizer #851

wants to merge 10 commits into from

Conversation

fknemi
Copy link

@fknemi fknemi commented Dec 28, 2022

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

Type of change

Added new play "Audio-Visualizer"

How Has This Been Tested?

  • I verified my changes through end-to-end testing across all viewports.

Checklist:

  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing unit tests pass locally with my changes
  • New Play (non-breaking change which adds functionality)

@vercel
Copy link

vercel bot commented Dec 28, 2022

@DyingintheDarkness is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel.

@reactplay first needs to authorize it.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Thank you for your contribution 😊.
Please reference the issue number in the description if you are fixing a bug.
If you are implementing a feature request, please check with the maintainers that the feature will be accepted first.
Stale Marking : After 30 days of inactivity this PR will be marked as stale PR and it will be closed and locked in 7 days if no further activity occurs.

@vercel
Copy link

vercel bot commented Jan 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-play ❌ Failed (Inspect) Jan 3, 2023 at 5:46AM (UTC)

@atapas
Copy link
Member

atapas commented Jan 3, 2023

@DyingintheDarkness Could you please resolve the conflicts?

@atapas
Copy link
Member

atapas commented Jan 12, 2023

@DyingintheDarkness Could you please resolve the conflicts?

Any update?

@fknemi
Copy link
Author

fknemi commented Jan 12, 2023

@DyingintheDarkness Could you please resolve the conflicts?

Any update?

I have fixed the conflicts. I have ran the tests and all are passing.

@fknemi
Copy link
Author

fknemi commented Jan 21, 2023

can you check up on it? any thing i need to change...? i have resolved conflicts @atapas

@github-actions
Copy link

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale. This PR will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions!

@github-actions github-actions bot added the stale label Feb 25, 2023
@github-actions github-actions bot closed this Mar 7, 2023
@fknemi fknemi deleted the play/audio-visualizer branch September 13, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Add a Play]: Audio Visualizer
2 participants