Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to module signing instructions in the installation instruction #403

Closed
KayJay7 opened this issue Dec 30, 2022 · 3 comments
Closed
Assignees
Labels
0 | type: enhancement New feature or request
Milestone

Comments

@KayJay7
Copy link

KayJay7 commented Dec 30, 2022

If secure boot is enabled, the module won't load unless it's signed and the key is installed on the system; apparently dkms should take care of all this by default, but it did not for me (on fedora 37, which did not come with dkms preinstalled).
The current signing process is fairly easy and explained on the DKMS's readme in the module signing and secure boot sections.

I saw you had some instructions on how to setup signing and removed because they weren't needed anymore, but apparently they sometimes are, so it might be good to put them back.

An inexperienced user might not understand why it's not working and give up. And if they find the problem and look it up on google, they will find a lot of tutorials suggesting solutions similar to your old solution, which with current dkms are suboptimal.

I'm not suggesting to write the entire signing instructions in the readme, but you could add a couple lines saying "if you get this problem, follow the instruction at this [dkms's readme] link".

@kakra
Copy link
Collaborator

kakra commented Dec 30, 2022

Usually, such modules should ship with a native package which correctly signs the module. In the real world, tho, packages often do not exists and DKMS can be used instead. It is probably a bug that DKMS doesn't sign the modules in Fedora and should be reported there. Nevertheless, I'll add the link. Please keep this issue opened until it will be closed by that commit.

@kakra kakra added the 0 | type: enhancement New feature or request label Dec 30, 2022
@kakra kakra self-assigned this Dec 30, 2022
@kakra kakra added this to the v0.10 milestone Dec 30, 2022
@KayJay7
Copy link
Author

KayJay7 commented Dec 30, 2022

Thanks for the quick response.
Dkms does try to sign modules but it fails, it needs to be set up as per the link (providing a key pair and importing the certificate in shim). I assumed this was because I had to install dkms myself (while on other distros it comes installed by default).
Anyway, I will get in touch with the fedora dkms package maintainer to see if it's a mistake on their part or what.

@gpanders
Copy link

gpanders commented Dec 2, 2023

I know this is an old issue, but just wanted to point out that the linked instructions in the DKMS README helped me. I was unable to get xpadneo working before.

@kakra kakra closed this as completed in 74dd867 Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 | type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants