Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a configure.sh sript #69

Closed
atar-axis opened this issue Jan 4, 2019 · 14 comments
Closed

Add a configure.sh sript #69

atar-axis opened this issue Jan 4, 2019 · 14 comments

Comments

@atar-axis
Copy link
Owner

atar-axis commented Jan 4, 2019

It would be easier for most users if we offer a configuration script which

  1. shows the possible ones, and
  2. does the necessary sysfs settings

sudo ./configure.sh --combined_z_axis=true

If any of you wants to help, I would appreciate it!

@atar-axis atar-axis added 0 | type: enhancement New feature or request good first issue Good for newcomers labels Jan 4, 2019
@CodeCanna
Copy link
Contributor

CodeCanna commented Mar 12, 2019

I wouldn't mind working on this, I'm a little new to contributing to open source, and contributing in general but I would love to help. This would me my first contribution to any open source project.

@atar-axis
Copy link
Owner Author

Hey there! Thats nice, just open a pull request and I will merge it If it works 😊 If you have any kind of questions: feel free to ask :)

@CodeCanna
Copy link
Contributor

CodeCanna commented Mar 12, 2019

Cool I'm excited! Hey so just to make sure, the desired behavior is for the user is:

./configure
make
make install

or is ./configure.sh a custom configure script?

@CodeCanna
Copy link
Contributor

And I'm not clear on what you mean by:

  1. shows the possible ones, and
  2. does the necessary sysfs settings

Shows the possible ones what?
And does the necessary sysfs settings, does that mean set up the proper file system for install?

Thanks ;)

@atar-axis
Copy link
Owner Author

Ah,... that's a misunderstanding :D It is not this Kind of configure script - What the config script should do is helping the users to configure the driver by changing the sysfs files - see the Configure section in the README :)

@CodeCanna
Copy link
Contributor

Ok I'm gonna check it out now. Thanks for the pointer :)

@CodeCanna
Copy link
Contributor

Hey, would you rather have a cli menu, or cli args?

@atar-axis
Copy link
Owner Author

Hey there, i would definitely prefer a shell script :) Just as the Install/Update/Uninstall scripts. :)

@CodeCanna
Copy link
Contributor

CodeCanna commented Mar 12, 2019

I know you want a shell script, I'm wondering if you want args to be passed to it, or for the user to choose options as the script runs.

Example:

Do you want to enable xyz? (Y, N)

or something like

./configure.sh -debug_level xyz -blah

EDIT: I see your example above is ./configure.sh --combined_z_axis=true which I didn't see before so it looks like you were thinking arguments. Cool I'm just wondering :)

@atar-axis
Copy link
Owner Author

Ah sorry! I would then prefer Arguments to be passed, in case someone wants to automate it - but it's up to you! :)

@CodeCanna
Copy link
Contributor

Hi! I think I almost have a working script, I just don't know how to parse the arguments from Fake Dev Version parameter. It says the value ranges from 0 to 0xFFFF. I don't know how to handle that value.

@CodeCanna
Copy link
Contributor

It's ready for review!! 😄

@atar-axis
Copy link
Owner Author

atar-axis commented Mar 13, 2019

Hey :) Just Open a "pull request", then we can discuss it or merge it directly

@atar-axis
Copy link
Owner Author

see #82 and 769429b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants