Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some boards with GD SPI Flash is not supported #3

Open
zibofidus opened this issue Nov 27, 2021 · 1 comment
Open

Some boards with GD SPI Flash is not supported #3

zibofidus opened this issue Nov 27, 2021 · 1 comment

Comments

@zibofidus
Copy link

My friend bought one of the little scope and flashed the firmware but got Flash error on boot up.
Looking at code, it looks like the flash.c has flash ID checked for Windbond part.
GD 25Q64 has different ID, hence flash error.
Can you please add this patch in?

diff --git a/scope.c b/scope.c
index 4672a78..560394c 100644
--- a/scope.c
+++ b/scope.c
@@ -741,6 +741,8 @@ static void change_vertical_scale(int delta)
config.vertical_mult = config.calib_vs_mult[config.vertical_scale];
config.vertical_position_mv = config.vertical_position * vs_px_value[config.vertical_scale];

  • config.trigger_level_mv = config.trigger_level * vs_px_value[config.vertical_scale];
  • capture_set_vertical_parameters();
    capture_set_trigger_level(config.trigger_level_mv);
    draw_vertical_scale();

Thanks.

@ataradov
Copy link
Owner

The flash is not used for anything, so the check can just be removed. If you want to submit the pull request for that - I'll accept, otherwise I won't do any changed myself.

I don't understand what that other patch is. It is broken by formatting, so you need at least format it correctly and explain it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants