Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to save log event timestamps in UTC or a custom time zone #483

Closed
Piedone opened this issue Mar 12, 2021 · 4 comments
Closed

Ability to save log event timestamps in UTC or a custom time zone #483

Piedone opened this issue Mar 12, 2021 · 4 comments

Comments

@Piedone
Copy link

Piedone commented Mar 12, 2021

Currently, log events are always saved with DateTime.Now which will use the machine's time zone. Instead, I suggest either switch this to UTC so the times are always consistent regardless of where the tests are executed or make this configurable.

@YevgeniyShunevych
Copy link
Member

It sounds good, @Piedone. I don't want to change the current behavior, in respect to backward compatibility. But I can add a configuration property to set the TimeZoneInfo value or its Id value. The default will be TimeZoneInfo.Local. Then you'll be able to set it with TimeZoneInfo.Utc.

@Piedone
Copy link
Author

Piedone commented Mar 16, 2021

Sounds perfect!

@YevgeniyShunevych
Copy link
Member

Hey @Piedone. This feature is implemented be #498. It's going to be release with Atata v1.11.0 next week.

@Piedone
Copy link
Author

Piedone commented May 28, 2021

Great, thank you!

@Piedone Piedone closed this as completed May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants