Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule: MA0028 Optimize StringBuilder usage #19

Closed
davidkallesen opened this issue Dec 14, 2020 · 2 comments
Closed

Rule: MA0028 Optimize StringBuilder usage #19

davidkallesen opened this issue Dec 14, 2020 · 2 comments
Assignees

Comments

@davidkallesen
Copy link
Collaborator

Rule summary

Value
Title MA0028 Optimize StringBuilder usage
CheckId MA0028
Category Performance
Link https://github.com/meziantou/Meziantou.Analyzer/blob/master/docs/Rules/MA0028.md

What is the problem

I don't like this rule... because the use of string interpolation often provides better readability, and the performance problem here is in the compiler - and the compiler needs to be corrected instead.
Until the compiler is fixed, it is not a issue in real world scenarios.

Suggestion

disable this rule in root .editorconfig with dotnet_diagnostic.MA0028.severity = none

@davidkallesen davidkallesen changed the title Rule: MA0028 Rule: MA0028 Optimize StringBuilder usage Jan 15, 2021
@cjakobsen
Copy link
Contributor

Some of the cases looks to be relevant, change to info level.

@davidkallesen
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants