New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Same loss value is logged for different loss types #21

Open

madaan opened this issue Apr 4, 2020 · 0 comments

Contributor

madaan commented Apr 4, 2020 •

edited

Hi,

Seems like token level averaged NLL loss will be logged for all loss types:

comet-commonsense/src/train/train.py

Line 118 in 070aad1

loss.item() / self.opt.train.dynamic.bs,

If you can confirm that this is indeed an issue, I can submit a pull request.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment