Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why do not excludes "none" answers in ATOMIC datasets? #30

Closed
yongho94 opened this issue Feb 17, 2021 · 2 comments
Closed

Why do not excludes "none" answers in ATOMIC datasets? #30

yongho94 opened this issue Feb 17, 2021 · 2 comments

Comments

@yongho94
Copy link

yongho94 commented Feb 17, 2021

Hello, Sir.

I have something to ask you about this code.

I wonder a reason of why you do not exclude 'none' target answer.

Your code seems to include such data samples like "PersonX loses personX's sight xNeed none " as a training data or test data.

I think learning to generate 'none' dose not seems to meaningful.

And I found same thing in COMET-ATOMIC 2020.

Is there any specific reasons?

Thanks.

@Kelaxon
Copy link

Kelaxon commented Mar 22, 2021

@yongho94 I'm also confused about it. Did you figure it out?

@atcbosselut
Copy link
Owner

Commonsense knowledge graphs are incomplete (i.e., missing commonsense facts). There's a semantic difference between an annotation that says there is NO effect, intent, reaction, etc. to an event, and the lack of any annotation. One teaches the model there is NO precondition/postcondition. One teaches the model nothing.

When we use the model on new events (e.g., see the generated event graphs at the end of the paper), it can be useful to generate "none" as an effect, reaction, etc. if there are no pre-/post-conditions associated with that event.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants