Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EN]🧐Possible Some spelling error, missing comma, and etc. #402

Closed
JonathanSum opened this issue Jul 6, 2020 · 5 comments
Closed

[EN]🧐Possible Some spelling error, missing comma, and etc. #402

JonathanSum opened this issue Jul 6, 2020 · 5 comments

Comments

@JonathanSum
Copy link
Contributor

JonathanSum commented Jul 6, 2020 •
edited

image

image
blue points?
image
image

image

image
image

image
In L2, the erros...
If you feel some of them are fine, please feel free to ignore it and close it.
However, if some of them need to be fixed and some of ppl are going to do it, please feel free to them and close it.
@JonathanSum JonathanSum changed the title 🧐🧐🧐Some spelling error and suggestions on sentence for much more easier to understand 🧐🧐🧐Some spelling error, missing comma, suggestions on sentencing for much more easier to understand, and etc. Jul 6, 2020
@JonathanSum JonathanSum changed the title 🧐🧐🧐Some spelling error, missing comma, suggestions on sentencing for much more easier to understand, and etc. 🧐🧐🧐Some spelling error, missing comma, suggestions on sentence structure for much more easier to understand, and etc. Jul 7, 2020
@JonathanSum JonathanSum changed the title 🧐🧐🧐Some spelling error, missing comma, suggestions on sentence structure for much more easier to understand, and etc. [EN]🧐🧐🧐Some spelling error, missing comma, suggestions on sentence structure for much more easier to understand, and etc. Jul 7, 2020
@JonathanSum JonathanSum changed the title [EN]🧐🧐🧐Some spelling error, missing comma, suggestions on sentence structure for much more easier to understand, and etc. [EN]🧐Some spelling error, missing comma, suggestions on sentence structure for much more easier to understand, and etc. Jul 7, 2020
@JonathanSum JonathanSum changed the title [EN]🧐Some spelling error, missing comma, suggestions on sentence structure for much more easier to understand, and etc. [EN]🧐Some spelling error, missing comma, and etc. Jul 7, 2020
@JonathanSum JonathanSum changed the title [EN]🧐Some spelling error, missing comma, and etc. [EN]🧐Possible Some spelling error, missing comma, and etc. Jul 7, 2020
@Atcold
Copy link
Owner

Atcold commented Jul 10, 2020

image

🤣🤣🤣

@Atcold
Copy link
Owner

Atcold commented Jul 10, 2020

image

What's up? What's that red bar?

image
blue points?

Yes, points.

image

image

  • […] second contrastive term […]
  • By transitivity, […]
  • […] for separating this out was that it stabilized training […]
  • Evaluation can be performed by full fine-tuning (initialisation evaluation) or training a linear classifier (feature evaluation).
  • PIRL robustness has been tested by using images in-distribution by training it on in-the-wild images.

This student just use the automated captions generated by Zoom. Probably because s/he did not understand what was going on in class.

image

Looks okay to me.

image

[…] other pretext tasks […]

image

Yes?

image
In L2, the erros...
If you feel some of them are fine, please feel free to ignore it and close it.
However, if some of them need to be fixed and some of ppl are going to do it, please feel free to them and close it.

Yes, the comma is missing.

Please, feel free to send a PR with these corrections!
Thank you so much for spotting these typos! I did not have the time to read everything though. I've mostly skimmed these contributions, and I'm still behind with the video editing process.

@Atcold
Copy link
Owner

Atcold commented Jul 25, 2020

@JonathanSum, can you fix these issues on the English version and send a PR?

@JonathanSum JonathanSum mentioned this issue Jul 25, 2020
Merged
@JonathanSum
Copy link
Contributor Author

JonathanSum commented Jul 26, 2020 •
edited

@Atcold
Of course, I have sent a PR 1 day ago.

Atcold added a commit that referenced this issue Aug 8, 2020
@Atcold
[EN]10-2,11-1 Fixing English errors according to the replies on #402 (#…
cd0d318 
…431)

* Fixing the english error

Signed-off-by: Jonathan Sum <777JonathanSum@gmail.com>

Co-authored-by: Alfredo Canziani <alfredo.canziani@gmail.com>
@Atcold
Copy link
Owner

Atcold commented Aug 8, 2020 •
edited

Awesome! You can close an issue by typing

Close #402

or

Fix #402

directly in the commit message or commit comment.

Anyhow, thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Atcold @JonathanSum