Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Including markdown comment in 10-1.md #439

Closed
goodboychan opened this issue Aug 4, 2020 · 4 comments · Fixed by #462
Closed

Including markdown comment in 10-1.md #439

goodboychan opened this issue Aug 4, 2020 · 4 comments · Fixed by #462

Comments

@goodboychan
Copy link
Contributor

When I tried to translate 10-1.md, I found that some markdown comment is included in the contents

Thus, getting annotated samples for categories towards the end of the tail requires huge quantities of data to be labelled [commenting out this redundant phrase]: <> (because of the nature of the distribution of categories).

I think it should be removed or modified.
How can I handle this?

Thanks in advance.
@Atcold
Copy link
Owner

Atcold commented Aug 8, 2020

Yeah, please remove that sentence in parenthesis.
In your commit message add Fix #439, to close this issue automatically when the PR gets merged.

@goodboychan
Copy link
Contributor Author

Sorry for late response.
Someone already fix the comment.

@goodboychan goodboychan mentioned this issue Aug 20, 2020
Merged
@goodboychan goodboychan reopened this Aug 20, 2020
@Atcold
Copy link
Owner

Atcold commented Aug 21, 2020

Oh, is this issue still relevant? I saw you closed it and reopened it.

@goodboychan
Copy link
Contributor Author

Right,
I didn't notice that part was remained.
I submitted the PR for correction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[KR] Add 10.md & remove markdown comments goodboychan/pytorch-Deep-Learning
2 participants
@Atcold @goodboychan