Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

problem with deepNotEqual in client/util.js #20

Open
ashwin-sporttotal opened this issue Mar 3, 2021 · 0 comments
Open

problem with deepNotEqual in client/util.js #20

ashwin-sporttotal opened this issue Mar 3, 2021 · 0 comments

Comments

@ashwin-sporttotal
Copy link

Hi,
I was facing some problems with hub subscriptions not getting new values after I add fields to an object in the data. I have been able to track the issue back to deepNotEqual implementation in hub/client/util.js

for a = {
cookieOk: 'Cookie Ok1',
class: 'Class',
payPerViewRemainingDays: 'Time Remaining: {{value}} Days',
sponsorThis: 'Sponsor this',
support: 'Support',
changedYourVote: 'Changed vote',
association: 'Association',
sharemessage: "For all the fans who can't be there - check it out live at sporttotal",
autoGeneratedForTesting6mf6r0k: '7g9sf9121311',
learnMore: 'Learn more',
player: 'Player',
blocked: 'Sorry this content is not available in your region',
removedFavourite: 'Removed from favourites',
season: 'Season',
club: 'Club',
liveMatches: 'Live matches',
payPerViewBuyButton: 'Buy for',
searchPlaceholder: 'What are you looking for?',
thanksForVoting: 'Thanks for voting',
competition: 'Competition',
payPerViewRemainingMinutes: 'Time Remaining: {{value}} Minutes',
video: 'Video',
password: 'Password',
sport: 'Sport',
location: 'Location',
embed: 'Embedded',
men: 'Men',
share: 'Share',
payPerViewWatchOnWeb: 'Watch this on sporttotal.tv!',
live: 'Live',
cannotVoteTwiceForTheSameItem: "You can't vote twice",
visitWebsite: 'Visit website',
team: 'Team',
sponsorThisClub: 'Advertise for this club',
region: 'Region',
event: 'Event',
payPerViewRemainingHours: 'Time Remaining: {{value}} Hours',
myTeams: 'My Teams',
yourVote: 'Your vote',
auto_test_key: '08gy91',
women: 'Women',
updateKey: 'hqd5ic',
autoTestKey: 'asdfaa',
transactionFailedMessage: 'Sorry, your transaction could not be processed.',
faq: 'FAQ',
partner: 'Partner',
match: 'Match',
contact: 'Contact',
payPerViewBuyAgainButton: 'Buy Again for',
sponsorship: 'Ad Portal',
category: 'Category',
ad: 'Ad',
exploreAll: 'Explore',
legalDocuments: 'Terms of use',
imprint: 'Imprint',
autoGeneratedForTestings3tx0m: 'r8tyyp',
addYourFavourites: 'Add your favourites by pressing the + button on any page',
sponsorThisMatch: 'Sponsor this match',
show: 'Show',
privacyPolicy: 'Privacy policy',
reprocessableTransactionFailedMessage: 'Sorry, your transaction could not be processed. Please try again.',
myFavourites: 'My Favourites',
payPerView: 'Pay Per View',
partners: 'Partners',
camera: 'Camera',
noFavourites: 'No teams added yet',
cookieSettings: 'Cookie Settings',
addedFavourite: 'Added to favourites',
cookieMessage: 'This website uses cookies',
information: 'Information',
article: 'Article',
__created_for_automated_testing_app_hub: 'trsy4j'
}

and, b = {
cookieOk: 'Cookie Ok1',
class: 'Class',
payPerViewRemainingDays: 'Time Remaining: {{value}} Days',
sponsorThis: 'Sponsor this',
support: 'Support',
changedYourVote: 'Changed vote',
association: 'Association',
sharemessage: "For all the fans who can't be there - check it out live at sporttotal",
autoGeneratedForTesting6mf6r0k: '7g9sf9121311',
learnMore: 'Learn more',
player: 'Player',
blocked: 'Sorry this content is not available in your region',
removedFavourite: 'Removed from favourites',
season: 'Season',
club: 'Club',
liveMatches: 'Live matches',
payPerViewBuyButton: 'Buy for',
searchPlaceholder: 'What are you looking for?',
thanksForVoting: 'Thanks for voting',
competition: 'Competition',
payPerViewRemainingMinutes: 'Time Remaining: {{value}} Minutes',
video: 'Video',
password: 'Password',
sport: 'Sport',
location: 'Location',
embed: 'Embedded',
men: 'Men',
share: 'Share',
payPerViewWatchOnWeb: 'Watch this on sporttotal.tv!',
live: 'Live',
cannotVoteTwiceForTheSameItem: "You can't vote twice",
visitWebsite: 'Visit website',
team: 'Team',
sponsorThisClub: 'Advertise for this club',
region: 'Region',
event: 'Event',
payPerViewRemainingHours: 'Time Remaining: {{value}} Hours',
myTeams: 'My Teams',
yourVote: 'Your vote',
auto_test_key: '08gy91',
women: 'Women',
updateKey: 'hqd5ic',
autoTestKey: 'asdfaa',
transactionFailedMessage: 'Sorry, your transaction could not be processed.',
faq: 'FAQ',
partner: 'Partner',
match: 'Match',
contact: 'Contact',
payPerViewBuyAgainButton: 'Buy Again for',
sponsorship: 'Ad Portal',
category: 'Category',
ad: 'Ad',
exploreAll: 'Explore',
legalDocuments: 'Terms of use',
imprint: 'Imprint',
autoGeneratedForTestings3tx0m: 'r8tyyp',
addYourFavourites: 'Add your favourites by pressing the + button on any page',
sponsorThisMatch: 'Sponsor this match',
show: 'Show',
privacyPolicy: 'Privacy policy',
reprocessableTransactionFailedMessage: 'Sorry, your transaction could not be processed. Please try again.',
myFavourites: 'My Favourites',
payPerView: 'Pay Per View',
partners: 'Partners',
camera: 'Camera',
noFavourites: 'No teams added yet',
cookieSettings: 'Cookie Settings',
addedFavourite: 'Added to favourites',
cookieMessage: 'This website uses cookies',
information: 'Information',
article: 'Article'
}

deepNotEqual(a,b) incorrectly returns false.. but deepNotEquals(b,a) correctly returns true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant