Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

with "locationType" var set to "hash" the "Details" Button in warning/error messages has wrong target #11

Open
mukil opened this issue Apr 26, 2017 · 0 comments

Comments

@mukil
Copy link
Contributor

mukil commented Apr 26, 2017

When clicking on the "Details" button (under the following circumstances) the user is thrown out of the visualization dialog (step2) and straight back to the frontpage of Khartis (step 1). Which is a bit unfortunate.

This seems only to be the case when Khartis was built with the following environment variable:
locationType: 'hash'

To reproduce, for example, click on the "Details" button in warning/error message which is shown when you choose the "Category > Area" visualization option for a layer but you have too many categories.

This locationType seemed necessary to adjust for me because I wanted (a) that deep links into the application remain functional and (b) Khartis is deployed through simply dropping the contents of the dist folder into an Apache (a document root served via a barebone Apache HTML configuration). In this case, it may be that there are other button affected but I haven't found one.

In a Khartis version built where locationType is set auto the very same "Details" button (mentioned above) seems to have no further functionality at all. If that is not by mistake we may want to remove it entirely, no?

Thanks for your support!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant