BlockingQueueObjectPool.getObj() must be synchronized

[GoogleCodeExporter]

With concurrent accesses you have to synchronize the getObj() method.
If not totalSize will always be the min size defined for the pool and not grows 
correctly.

public synchronized T getObj() throws PoolException { ... }

Check on concurrent accessed methods please. ;)

Best regards,
Daniele Bonetto

Original issue reported on code.google.com by daniele....@gmail.com on 18 Apr 2013 at 8:09

[GoogleCodeExporter]

OK, modifications are done.

I upload a jar on the download area (objectpool-1.1.3-snapshot.jar).

Best regards,
Eddie Raapoto

Original comment by eddie.ra...@gmail.com on 18 Apr 2013 at 9:16

• Changed state: Started

[GoogleCodeExporter]

Every time you can access concurrently to queue and totalSize i suppose you've 
to use synchronized (like returnObj and destroyObject methods).
If not in multi-thread active/idle count will be incorrect, etc.

Regards,
Daniele Bonetto

Original comment by daniele....@gmail.com on 18 Apr 2013 at 9:36

[GoogleCodeExporter]

It strange, because the queue "java.util.concurrent.ConcurrentLinkedQueue" is 
already synchronized.
The totalSize variable "java.util.concurrent.atomic.AtomicInteger" is also 
thread safe.

Original comment by eddie.ra...@gmail.com on 18 Apr 2013 at 11:12

[GoogleCodeExporter]

Hi, i've tried to shutdown pool while idling objects.
When retrieving idles instances counter was the same as before shutdown.

Shutdown don't close idle connections or idles property wasn't synchronized.
Check it please.

Regards,
Daniele

Original comment by daniele....@gmail.com on 13 May 2013 at 10:43

[GoogleCodeExporter]

Hi, do u have implemented PoolableObject.destroy(T t) method in your pool 
definition ?
Regards, Eddie

Original comment by eddie.ra...@gmail.com on 16 May 2013 at 8:47

[GoogleCodeExporter]

Of course and it works.
I think the problem is with counters cause happens that with a max connection 
of 5 actives returns a greater number (eg. 7/8).
I suppose there's some problem when getObject fails, but not jet checked on 
sources.

I call getObject under try/finally (where i release obj if not null).

Regards,
Daniele

Original comment by daniele....@gmail.com on 16 May 2013 at 10:44