-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thumbs.db inverted reversed blue/red channels #3
Comments
Yes, it does look like red is blue and blue is red. I can only speculate that the idiots at MS were (again) attempting to obfuscate an otherwise open format...JPEG...when they developed the thumbs.db format. I'm glad they got with the program in their later refactoring. I'll look at updating the code. It may be that the images were matrix inverted which also swapped the red and blue channels. That would also account for the upside down, inverted image issues. This would fix all these perceived individual issues in one simple fix. I've been validating the image format in the binary encoding, but it's a PITA. If only I could find some actual documentation on this old format... Thanks for finding this issue. |
Oops. |
As per issue #2, you can do the following to test.
Note the red and blue transpose. |
Thanks for the samples. I think I've resolutely fixed the Type 1 issues now that I've taken a deeper dive. The "invert" option is no longer needed. Check out the new release. |
Just checked out the latest version, it works great! All the thumbs look spot on perfect now, no odd colorization issues. Thanks for digging into that and solving it! |
Greetings
Thanks so much for providing the invert option, it really works great. However I have come across a Thumbs.db file where the invert worked great, except the
red
in the image comes outblue
.Attached is the Thumbs.db.zip
Here is the original image:
![koc_auto](https://user-images.githubusercontent.com/81436/154845346-2cdbfe04-2bf8-4b2a-96c0-f985f42617a4.jpg)
Here is the thumbnail extracted with the
![koc_auto_thumb_inverted](https://user-images.githubusercontent.com/81436/154845426-83046bf0-e797-4dc3-9772-02d0a07b9402.jpg)
--invert
option:And here it is without
![koc_auto_thumb](https://user-images.githubusercontent.com/81436/154845432-bd672910-b34c-43be-bc75-aa42f6391275.jpg)
--invert
:As you can see,
--invert
really helps a lot, but the blue taillights should be red. Perhaps the channel conversion is buggy in some way? Or maybe this is just the way the Thumbs.db format works and there isn't a solution.Once again, thanks for creating Vinetto.
The text was updated successfully, but these errors were encountered: