Skip to content
This repository has been archived by the owner on Jun 24, 2021. It is now read-only.

Trailing space in CAP ACK #110

Closed
progval opened this issue Dec 23, 2015 · 1 comment
Closed

Trailing space in CAP ACK #110

progval opened this issue Dec 23, 2015 · 1 comment

Comments

@progval
Copy link
Contributor

progval commented Dec 23, 2015

Session log, with pipes added at the end of lines so you can see the issue:

1450898955.283 1: connects to server.
1450898955.283 1 -> S: CAP LS 302|
1450898955.283 S -> 1: :My.Little.Server NOTICE * :*** Looking up your hostname...|
1450898955.283 S -> 1: :My.Little.Server NOTICE * :*** Checking Ident|
1450898955.283 S -> 1: :My.Little.Server NOTICE * :*** No Ident response|
1450898955.283 S -> 1: :My.Little.Server NOTICE * :*** Found your hostname|
1450898955.283 S -> 1: :My.Little.Server CAP * LS :account-notify away-notify cap-notify chghost extended-join multi-prefix tls userhost-in-names|
1450898955.283 1 -> S: CAP REQ :foo multi-prefix bar|
1450898955.324 S -> 1: :My.Little.Server CAP * NAK :foo multi-prefix bar|
1450898955.324 1 -> S: CAP REQ :multi-prefix bar|
1450898955.363 S -> 1: :My.Little.Server CAP * NAK :multi-prefix bar|
1450898955.364 1 -> S: CAP REQ :foo multi-prefix|
1450898955.403 S -> 1: :My.Little.Server CAP * NAK :foo multi-prefix|
1450898955.404 1 -> S: CAP REQ :multi-prefix|
1450898955.443 S -> 1: :My.Little.Server CAP * ACK :multi-prefix |

Mammon has a similar issue, but it is a temporary hack to support mIRC. But in Mammon it affects NAK too and not in Charybdis, so I guess this is not the case in Charybdis.

@kaniini
Copy link
Contributor

kaniini commented Dec 28, 2015

This is due to an optimization in clicap_generate(). As it is solely a cosmetic issue, we are not likely to change it, but a patch would be accepted if submitted.

@kaniini kaniini closed this as completed Dec 28, 2015
progval added a commit to progval/charybdis that referenced this issue Dec 28, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants