add -l / --long flag #63
Conversation
|
@GladOSkar - Can you also update the |
|
I just noticed i forgot to check rubocop and rspec. Give me some more time... |
|
Why did this fail here? rubocop went fine on my machine... |
|
@GladOSkar - Travis always tests on the current master. You might have tested rubocop on a previous master. Anyways, seeing the Travis CI build report, I think
|
|
the date is currenntly green if it has been modified less than an hour ago, yellow if it has been modified less than 24 hours ago and white otherwise. if that is too complicated i can remove it. the icon thing i can do of course |
|
@GladOSkar - Ah, nice. Didn't see the code for the date coloring. This looks good as it is. 👍 Also, is there some issue with indentation when access permission on any one row is lengthier than the others? |
| stat = File.stat(content) | ||
| "#{mode_info(stat)} #{user_info(stat)} #{group_info(stat)} #{size_info(stat)} #{mtime_info(stat)}" | ||
| end | ||
|
|
There was a problem hiding this comment.
Maybe using a "\t" instead of space between each variable would do a better job of indenting? Like,
"#{mode_info(stat)}\t#{user_info(stat)}\t#{group_info(stat)}\t#{size_info(stat)}\t#{mtime_info(stat)}"There was a problem hiding this comment.
I tried it but it made way too big gaps. So i wrote some logic for that
There was a problem hiding this comment.
Currently, if the -l flag is passed, it calculates the longest user- and group name upon initialization and ljusts the names accordingly
There was a problem hiding this comment.
Hmm, looking at this screenshot, are the disturbances in lines 348 & 354 intended to be? (Like, 0;33;49m in rwx0;33;49mr-xr-x)
I think this is some unintended extension, and if taken care of, indentation should be proper by it's own.
There was a problem hiding this comment.
No, and i don't get how that can happen since the code just replaces ones and zeroes there... I'll have a look
There was a problem hiding this comment.
Did you make that screenshot on your machine? If yes - what is your output of ls -l?
There was a problem hiding this comment.
Funnily, i do not see those Artifacts here: https://travis-ci.org/athityakumar/colorls/jobs/251976299
There was a problem hiding this comment.
Ah. I think I was looking at a previous build. Build 112 seems great! 👍
There was a problem hiding this comment.
OK so \e[0;33;49m is what has to be inserted i a terminal to produce yellow, and apparently travis swallowed 2-3 characters in each case, making the rest of the characters appear. i cannot image that happening in a real environemnt though
|
Can we just increase the class length limit or do i really have to make an extra class for that? I think it fits the way it is... |
|
@GladOSkar - No need for a new class, but I think the class methods can be truncated to fit 200 lines. If not, we can temporarily increase it and fix it after the feature is added. But of course, matching Rubocop's specs is favorable. 😄 |
| end | ||
| user.to_s.length | ||
| end.max | ||
| end |
There was a problem hiding this comment.
This begin-rescue block can be single-lined...
user = Etc.getpwuid(File.stat(c).uid).name rescue File.stat(c).uid| rescue ArgumentError | ||
| group = File.stat(c).gid | ||
| end | ||
| group.to_s.length |
There was a problem hiding this comment.
... and so can this begin-rescue block.
| rescue ArgumentError | ||
| group = stat.gid | ||
| end | ||
| group.to_s.ljust(@grouplength, ' ') |
There was a problem hiding this comment.
... and this begin-rescue block
|
@GladOSkar - Added some review comments to shorten the class length. 😄 |
|
@GladOSkar - Alright, let's change the |
|
Now it doesn't like the rescues ^^ |
|
@GladOSkar - Hmm, revert the |
|
I was just reading up on .try() , i think that may solve it. give me a sec |
|
It didn't. But rubocop should be fine now. |
As discussed in #40.
It became less elegant than i wanted it to be, so let me know if i can make it any better :)
Also while researching i found exa. They have a lot of similar and interesting features.