Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider making public crontab field types private #72

Closed
atifaziz opened this issue Oct 27, 2020 · 2 comments
Closed

Consider making public crontab field types private #72

atifaziz opened this issue Oct 27, 2020 · 2 comments
Assignees
@atifaziz
Labels
bug

Comments

@atifaziz
Copy link
Owner

Types like ICrontabField and CrontabField needn't be public. Not even the tests require their public access. Consider making them private for the next major release.

This is a design bug.
@atifaziz atifaziz added the bug label Oct 27, 2020
@atifaziz atifaziz added this to the 4.0.0 milestone Oct 27, 2020
@atifaziz atifaziz self-assigned this Oct 27, 2020
@atifaziz atifaziz mentioned this issue Oct 27, 2020
Closed
@MatisseHack
Copy link

This would be a breaking change for me. I certainly understand wanting to simplify the public interface, but I hope that CrontabField can be kept around 🤞

@atifaziz atifaziz removed this from the 4.0.0 milestone Oct 28, 2020
@atifaziz
Copy link
Owner Author

Abandoning based on feedback from @MatisseHack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atifaziz atifaziz

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@atifaziz @MatisseHack