Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package references contains duplicates #19

Closed
vcaraulean opened this issue Mar 27, 2017 · 2 comments
Closed

Package references contains duplicates #19

vcaraulean opened this issue Mar 27, 2017 · 2 comments

Comments

@vcaraulean
Copy link
Contributor

An extract from csx:

#r "packages\System.ValueTuple.4.3.0\lib\netstandard1.0\System.ValueTuple.dll"
#r "packages\System.ValueTuple.4.3.0\lib\netstandard1.0\System.ValueTuple.dll"
#r "packages\System.ValueTuple.4.3.0\lib\netstandard1.0\System.ValueTuple.dll"
#r "packages\System.ValueTuple.4.3.0\lib\netstandard1.0\System.ValueTuple.dll"
#r "packages\System.Xml.ReaderWriter.4.3.0\lib\net46\System.Xml.ReaderWriter.dll"
#r "packages\System.Xml.XPath.4.3.0\lib\net46\System.Xml.XPath.dll"
#r "packages\System.Xml.XPath.XDocument.4.3.0\lib\net46\System.Xml.XPath.XDocument.dll"
#r "packages\System.Xml.XPath.XDocument.4.3.0\lib\net46\System.Xml.XPath.XDocument.dll"

It might look harmless. For traditional targets (like net461) where number of potential references is low there is little overhead. For netstandard targets reference lookup takes 10-20 seconds (running in console), ending up with a list of over 300 lines for the example from #13, lots of duplicates.

Some caching/tracking of "seen" items is probably welcome. Process will be faster and will contain no duplicates.

@atifaziz
Copy link
Owner

Closed by 185713c

@atifaziz
Copy link
Owner

Some caching/tracking of "seen" items is probably welcome. Process will be faster and will contain no duplicates.

This is a good idea but probably needs to be tracked as a separate issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants