Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Words still cut out of the picture #14

Closed
kernc opened this issue Apr 26, 2013 · 3 comments
Closed

Words still cut out of the picture #14

kernc opened this issue Apr 26, 2013 · 3 comments

Comments

@kernc
Copy link
Contributor

kernc commented Apr 26, 2013

Kudos,

Using PyTagCloud to amend my CV with relevant keywords, I found words still get offset out of the image.

While @konstantint's issue #12 helps considerably, I experienced truncation until I replaced https://github.com/atizo/PyTagCloud/blob/master/pytagcloud/__init__.py#L355
image_surface = Surface((sizeRect.w, sizeRect.h), SRCALPHA, 32)
with
image_surface = Surface((sizeRect.w + 2*TAG_CLOUD_PADDING, sizeRect.h + 2*TAG_CLOUD_PADDING), SRCALPHA, 32)
Not sure if this is a fix, though, but it helped in my case.

@konstantint
Copy link
Contributor

Looks like a valid fix to a valid bug (that I seem to have introduced) indeed. You should probably suggest the edit as a proper pull request.

@aeby
Copy link
Member

aeby commented Apr 30, 2013

Thanks for the hint and fix.
@kernc Can you create a pull request with this fix please?

kernc added a commit to kernc/PyTagCloud that referenced this issue Apr 30, 2013
@kernc
Copy link
Contributor Author

kernc commented Apr 30, 2013

Submitted.
Thank you both.

aeby pushed a commit that referenced this issue Apr 30, 2013
PR for issue #14: Words still cut out of the picture
@aeby aeby closed this as completed Nov 14, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants