code duplication in Query:_render_* methods

[DarkSide666]

This piece of code is found in _render_where, _render_orwhere, _render_andwhere, _render_having:

        if (!isset($this->args['where'])) {
            return;
        }

It can me moved to __render_where method to not duplicate code:

        if (!isset($this->args[$kind])) {
            return;
        }

and in previously mentioned methods do simply like this:

    protected function _render_orwhere()
    {
        $ret = $this->__render_where('where');
        return $ret ? implode(' or ', $ret) : null;
    }

[romaninsh]

I have commented on this i think, but just in case - we can't move this into __render_where, because the wrapping methods would typically prepend " having", " where" and if there are no clauses at all, we should return null, that's why this check is done on the top-level.

[DarkSide666]

not sure I understood your comment :)

        $ret = $this->__render_where('where');
        return $ret ? implode(' or ', $ret) : null;

should do that same thing.

[romaninsh]

Yeah, but I've read in the code developer guidelines to return from methods early if possible.

It's not a huge deal really. Plus all of the _render() methods have the same code to return 'null' if their presence is not needed. Perhaps we can even move it to render() method, but I'm not sure at this time if it can create more problems or not.

When in doubt, leave as-is.

[DarkSide666]

I agree.