Multiple Address Support Request

[anvari1313]

What do you think about adding multiple addresses support? For example for HTTP it can be something like this:

wait4x http http://srv1:8080,http://srv2:8080

If both http://srv1:8080 and http://srv2:8080 return the expected result, wait4x exits successfully and otherwise it should be failed.

Maybe we can use comma separated string that is mentioned above or split strings like this:

wait4x http http://srv1:8080  http://srv1:8080

It can help us a lot to improve our deployment process.

[atkrad]

Hi Ahmad,

Thanks for your suggestion. It is an interesting feature. If we want to implement that with multiple arguments, Maybe it has a conflict with the #22 or other parts of Wait4X.
Anyway, We need time to think about that to find the best solution for implementing that.

Is it possible to explain your use case on the deployment process? Maybe I can suggest another solution.

[anvari1313]

Hi Mohammad,

As you know, we use initContainers in k8s Deployment for our API gateway to check the healthiness of upstream backends (in On-Demand Environments). For each service, there's a wait4x container sending an HTTP request to it. As the number of microservices grows, more init containers are added and it makes API gateway pod restarts very time-consuming (For example for a config change).
A simple solution is to run all of them in just one container and chain wait4x commands with && of bash. The issue is it doesn't provide enough visibility about which services have issues unless we set the log level of wait4x to debug.
I was thinking that maybe checking multiple addresses with more detailed logs can be a useful feature.

By the way, I would be glad to contribute if you decide to have this feature.

[atkrad]

Hi Ahmad,

Based on our conversation. You can try our new feature https://github.com/atkrad/wait4x#command-execution to have a single initContainer instead of multiple of initContainer.

If the feature doesn't resolve your issue, I would gladly accept a pull request for that.

[anvari1313]

Hi Mohammad,

Thanks for your suggestion. It will reduce the number of initContainers

[atkrad]

Hi @anvari1313,

Currently, Wait4X supports multiple inputs like this:

wait4x tcp localhost:8081 localhost:8082 localhost:8083 -t300s

It checks all of the inputs paralleled. I hope the feature can be helpful for you.