Skip to content
This repository has been archived by the owner on Aug 25, 2020. It is now read-only.

Undesired playback behavior at the end of experiments #7

Open
leonoverweel opened this issue Mar 15, 2017 · 2 comments
Open

Undesired playback behavior at the end of experiments #7

leonoverweel opened this issue Mar 15, 2017 · 2 comments

Comments

@leonoverweel
Copy link
Contributor

At the end of an experiment, the following playback issues occur:

  • The rooms/ racks/ machines stay in the last state of load they were in during simulation, and do not go back to being at zero load.
  • The timeline is one second longer than how far the experiment runs, so to the user it appears that it never reaches the end
@gandreadis
Copy link
Member

1/ I'd argue that this is desired behavior: When you are at a certain tick, the load of that tick should be displayed. When you are on the last position of the timeline, the state of that last tick is displayed. Later, we may overlay a screen at this point, linking to a page with a statistic overview of the played experiment, but for now, I think this is entirely sufficient.

2/ You are right, and the reason for this is the following: When I divide the timeline into n+1 chunks (with n being the last tick, and the +1 being for the first tick =0), these chunks may be larger than the time marker itself. When this is the case, the marker is just put on the left-most position of that chunk. This is accurate for tick 0 (you expect the marker to begin all the way on the right), but becomes less desirable for the later ticks. The latest tick is then offset exactly width/(n+1) pixels to the right of the timeline end. To solve this, I need to add some linearly increasing offset to the time marker position, depending on the current tick. It is on the roadmap for the frontend, although perhaps with medium priority. I'll let you know once I have updates on this.

@leonoverweel
Copy link
Contributor Author

1/ Sounds good to me.

2/ Makes sense, thanks for the update!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants