Skip to content
This repository has been archived by the owner on Nov 17, 2017. It is now read-only.

AtlasService.converterCheck() contains incomplete code #273

Closed
jpav opened this issue Nov 2, 2017 · 3 comments
Closed

AtlasService.converterCheck() contains incomplete code #273

jpav opened this issue Nov 2, 2017 · 3 comments
Labels

Comments

@jpav
Copy link
Contributor

jpav commented Nov 2, 2017

Code near the end of the method that determines whether a response should be generated indicating a converter is needed to perform a mapping has been left incomplete. We should determine the necessity of this code and either complete its implementation or remove it from the class.

jpav added a commit to jpav/atlasmap-runtime that referenced this issue Nov 2, 2017
jpav added a commit to jpav/atlasmap-runtime that referenced this issue Nov 2, 2017
@igarashitm
Copy link
Contributor

Weird thing is that we sometimes see "converter is not available" warning in UI. I thought it came from this converterCheck. Need to investigate.

@igarashitm igarashitm added the bug label Nov 2, 2017
@igarashitm
Copy link
Contributor

I now suspect the converterCheck is not used at all. All the converter validation results I have ever seen come from validate. Make sure UI doesn't invoke it and remove.

@igarashitm
Copy link
Contributor

Issue moved to atlasmap/atlasmap #14 via ZenHub

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants