Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comma in expand query param causes issue if URL encoded #1386

Closed
amitjoy opened this issue May 7, 2024 · 2 comments
Closed

Comma in expand query param causes issue if URL encoded #1386

amitjoy opened this issue May 7, 2024 · 2 comments

Comments

@amitjoy
Copy link

amitjoy commented May 7, 2024

I just found out that if the comma in expand query param is URL encoded, the request returned 404 whereas if the comma is used in the expand param to separate the list, it is accessible

For example:

https://SERVER/rest/api/content?spaceKey=PRS&limit=100&status=current&expand=body.storage,version&type=page
https://SERVER/rest/api/content?spaceKey=PRS&limit=100&status=current&expand=body.storage%2Cversion&type=page

I am not able to retrieve the page content due to this issue at all. Could anyone kindly have a look?

@amitjoy
Copy link
Author

amitjoy commented May 7, 2024

The following lines in atlassian.rest_client.AtlassianRestAPI.request causes the issue:

if params:
     url += urlencode(params or {})

@amitjoy amitjoy closed this as completed May 7, 2024
@gonchik
Copy link
Member

gonchik commented May 7, 2024

@amitjoy feel free to send PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants