Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing some dependencies stuff #214

Merged
merged 6 commits into from
Nov 4, 2019
Merged

fixing some dependencies stuff #214

merged 6 commits into from
Nov 4, 2019

Conversation

Noviny
Copy link
Collaborator

@Noviny Noviny commented Nov 4, 2019

Basically wanted to tidy up our dependencies to be more in line with using manypkg well. Primary focus was removing dependencies from root that didn't need to be at root, and then removing some things from packages that weren't actually used in those packages.

I also threw out and regenned the yarn.lock because /shrug

@changeset-bot
Copy link

changeset-bot bot commented Nov 4, 2019

🦋 Changeset is good to go

Latest commit: 1b6c713

We got this.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Nov 4, 2019

Codecov Report

Merging #214 into master will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #214      +/-   ##
==========================================
- Coverage   79.93%   79.84%   -0.09%     
==========================================
  Files          44       44              
  Lines        1176     1176              
  Branches      263      263              
==========================================
- Hits          940      939       -1     
- Misses        230      231       +1     
  Partials        6        6
Impacted Files Coverage Δ
packages/cli/src/utils/v1-legacy/removeFolders.ts 40% <ø> (ø) ⬆️
.../assemble-release-plan/src/determine-dependents.ts 97.5% <ø> (ø) ⬆️
packages/config/src/index.ts 100% <ø> (ø) ⬆️
packages/cli/src/commands/add/createChangeset.ts 61.01% <ø> (ø) ⬆️
packages/parse/src/index.ts 80% <0%> (-6.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5271b00...1b6c713. Read the comment docs.

@Noviny Noviny merged commit 9cd1eaf into master Nov 4, 2019
@Noviny Noviny deleted the noviny/tidying branch November 4, 2019 09:53
@github-actions github-actions bot mentioned this pull request Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants