Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint: markdown using prettier #486

Merged
merged 3 commits into from Nov 13, 2020
Merged

lint: markdown using prettier #486

merged 3 commits into from Nov 13, 2020

Conversation

maddhruv
Copy link
Contributor

@maddhruv maddhruv commented Nov 11, 2020

Lints all markdown files using prettier

Related - #31

@changeset-bot
Copy link

changeset-bot bot commented Nov 11, 2020

⚠️ No Changeset found

Latest commit: 0d9bd91

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

package.json Outdated
@@ -13,6 +13,7 @@
"lint:prettier": "prettier --list-different \"**/*.{js,ts,tsx}\"",
"types:check": "tsc",
"prettier": "prettier --write \"**/*.{js,ts,tsx}\"",
"prettier:md": "prettier --write \"**/*.md\"",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, I would prefer just adding this extension to the list in the prettier task. Similar should be done for the lint:prettier task as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 👍

@Andarist Andarist merged commit 57da996 into master Nov 13, 2020
@Andarist Andarist deleted the lint/everything branch November 13, 2020 15:33
@Andarist Andarist mentioned this pull request Nov 13, 2020
@maddhruv
Copy link
Contributor Author

Thanks @Andarist 🤗

@Andarist
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants