Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] - Allow the option to add annotations for Standalone synchrony service #398

Closed
1 task done
athira-1142 opened this issue Mar 23, 2022 · 3 comments · Fixed by #464
Closed
1 task done
Labels

Comments

@athira-1142
Copy link

Suggestion

We have to add annotations on the services to enable session affinity and create a health check (backend configuration). At present, we can add annotations through values.yaml only on confluence service. For standalone synchrony service, we have to add annotations after the application is deployed.

It would be great if there is an option to add annotations on Synchrony service in values.yaml as we can manage everything through Helm.

Product

Confluence

Code of Conduct

  • I agree to follow this project's Code of Conduct
@errcode1202
Copy link
Collaborator

errcode1202 commented Apr 5, 2022

Hi @athira-1142,

Thankyou for the suggestion. For context, and so we can better understand what you need, would you mind creating a PR with the proposed changes. We can use that then as a talking point as a potential addition to main.

@DarthKoax
Copy link
Contributor

This is a feature that we have discovered would be very helpful for us. We have run into the issue also with our build where Synchrony's health check and stickiness are configured incorrectly due to inheriting from our confluence ingress annotations.

This is recommended by Atlassian to have stickiness on for confluence and off for synchrony, along with health check pointing to /status for confluence and /sychrony/heartbeat for synchrony.
https://confluence.atlassian.com/confkb/how-to-configure-amazon-web-service-application-load-balancer-with-confluence-859515417.html

If athira-1142 has not already started a PR, we may look into doing so.

@altcourt
Copy link

altcourt commented Jun 9, 2022

+1 for helpfulness for our build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants