Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use semantic versioning/tags on the image #15

Open
JohannesRudolph opened this issue Sep 27, 2016 · 4 comments
Open

Use semantic versioning/tags on the image #15

JohannesRudolph opened this issue Sep 27, 2016 · 4 comments

Comments

@JohannesRudolph
Copy link
Contributor

JohannesRudolph commented Sep 27, 2016

Can you tag images with a version in addition to applying the latest tag? Makes it easier to consume these fantastic images :-)

See also: https://medium.com/@mccode/the-misunderstood-docker-tag-latest-af3babfd6375#.2rq93tci3 for how convoluted docker tags are...

@mark-adams
Copy link
Contributor

Sure! Do you have a suggestion for how you'd version them?

Most of the images that I've seen on Docker Hub tend to follow the underlying version of a framework or major software release. In this case, I'm already doing that with Python 2 vs Python 3 and I'd certainly be open to doing that with the JS images.

Any ideas are very much welcome!

@JohannesRudolph
Copy link
Contributor Author

I wouldn't mind if you just bumped a minor (e.g. 1.x) on each revision that doesn't contain breaking changes). The problem with this (and many other docker images) is that it's not 100% reproducible, e.g. the -js version installs node 6.x

RUN curl -sL https://deb.nodesource.com/setup_6.x | bash -
RUN apt-get install -y nodejs && npm install -g npm@latest

So the version on Docker Hub depends on the time the image was built.

On the other hand, just monotonically increasing the version would be fine with me as well. It's just meant to ensure people can pull an immutable image version from docker hub by tag.

@vkruoso
Copy link

vkruoso commented Mar 27, 2017

Just found the image and it works great for JS tests. This versioning scheme would be great. Otherwise, to have reproducible builds we need to build the image on our own. What can we do to help you on this?

@mark-adams
Copy link
Contributor

I started some work on this over the past few days: https://hub.docker.com/r/markadams/chromium-xvfb-js/tags/

The JS image now contains tags for 6.x and 7.x versions of Node and the exact versions are pinned in the Dockerfiles. Next, I'll probably create some tags for the minor versions as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants