Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Touch doesn't drag card but block in nested vertical list (Android only) #173

Closed
ThomasJuster opened this issue Nov 15, 2017 · 6 comments
Closed
Assignees
Labels

Comments

@ThomasJuster
Copy link

ThomasJuster commented Nov 15, 2017

Bug or feature request?

Bug

Expected behavior

In this example in the second level block, the user should be able to drag and drop the cards using touch.

Actual behavior

Using touch drags the whole second level block rather than just the card.

Steps to reproduce

Go to this doc page with your phone (or Chrome in mobile mode) and try to swap the two cards in the second level block

Browser version

Android: Chrome 62.0.3203.84
Computer: Chrome 62.0.3202.89 (Official Build) (64-bit)

@alexreardon
Copy link
Collaborator

Super strange. It only seems to be the case on android. It works as expected on iPhone. Must have something to do with how it publishes events. Super surprising that the outer element event handler gets called before the inner one

@alexreardon alexreardon changed the title Touch doesn't drag card but block in nested vertical list Touch doesn't drag card but block in nested vertical list (Android only) Nov 15, 2017
@alexreardon alexreardon self-assigned this Nov 15, 2017
@alexreardon
Copy link
Collaborator

We now prevent the propagation of the touchstart event while being careful to not call prevent default so as to maintain as much standard browser behaviour as possible

@humphreybc
Copy link

@alexreardon I bumped the version to 2.6.1 just now. I've been playing around on our staging environment and I'm running into this issue—so thanks for fixing—but I also can't scroll on the list anymore. Is this all related to this issue?

@alexreardon
Copy link
Collaborator

Thanks for raising this @ThomasJuster.

Not sure @humphreybc. I am about to do a new release. Please check against that or master. If you are still having issues please raise a seperate issue - cheers 👍

@alexreardon
Copy link
Collaborator

@humphreybc done.

Also, regarding scrolling - take a look at this: https://github.com/atlassian/react-beautiful-dnd/tree/v2.6.2#opting-out-of-native-scrolling

@humphreybc
Copy link

@alexreardon Thanks! Read through that and opened up an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants