Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced provided.isDragging with snapshot.isDragging in droppable.md file. #1981

Merged
merged 1 commit into from Mar 18, 2021

Conversation

agilatakishiyev
Copy link
Contributor

I think this is a mistake, because isDragging property does not exist in DroppableProvided type

@atlassian-cla-bot
Copy link

atlassian-cla-bot bot commented Oct 18, 2020

Hooray! All contributors have signed the CLA.

@agilatakishiyev agilatakishiyev changed the title Replaced provided.isDragging with snapshot.isDragging Replaced provided.isDragging with snapshot.isDragging in droppable.md file. Oct 18, 2020
@agilatakishiyev
Copy link
Contributor Author

hi there, can you please take a look at this pull request? there is not a big change actually but 😞 to see this is open for 15 days already.

Copy link
Collaborator

@danieldelcore danieldelcore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! Thanks!

Can confirm based on the DraggingMapProps type definition: src/view/draggable/draggable-types.js

🙏

@danieldelcore danieldelcore merged commit 4a14a3f into atlassian:master Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants