Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move decorator editing window within attribute editing window #927

Closed
noah-schechter opened this issue Feb 26, 2024 · 1 comment
Closed

Comments

@noah-schechter
Copy link
Collaborator

Current
Users configure the decorators for each attribute in a separate part of the Manage page from where they configure the corresponding attributes.

Proposed
I think users should configure decorators within the editing modal for the corresponding attribute. Is the issue here that that would crowd the modal?

@milesmcc
Copy link
Collaborator

There are four reasons why I didn't do this, three UX and one practical:

  • I suspect users will often want to edit decorators in bulk; having to go individually into each attribute and re-specify attribute values feels like a pain. In my mind it makes sense to think about all the decorators together.
  • I also think that it would indeed make the editor window crowded.
  • Decorators should be a rarely used feature; to the extent possible, I think we should remove them from the regular user flow.
  • It'd mean that we'd need to create popup modals for editing core attributes, which is a bit of a pain; it'd also require refactoring the Phoenix form, which would be annoying.

Closing for now but reopen if this explanation is not compelling and/or you feel strongly that it needs to be in the attribute editor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants