checking constants

[trontrytel]

https://github.com/atmos-cloud-sim-uj/PySDM/blob/fb619fa842ea419f6f038c532f07432f310f7e7a/PySDM/physics/aqueous_chemistry/support.py#L109

I'm not sure because of the comment left above this line, but shouldn't the value be 7.5 * 1e7?

[trontrytel]

Also, not sure if I understand correctly the table 4 in Kreidenweis. But in libcloudph++, I think, for both dissolution and dissociation of HNO3 I was taking 8700 as the exponent factor. In PySDM its 0 right now.

https://github.com/atmos-cloud-sim-uj/PySDM/blob/fb619fa842ea419f6f038c532f07432f310f7e7a/PySDM/physics/aqueous_chemistry/support.py#L32

https://github.com/atmos-cloud-sim-uj/PySDM/blob/fb619fa842ea419f6f038c532f07432f310f7e7a/PySDM/physics/aqueous_chemistry/support.py#L45

[slayoo]

Aniu! I have just rerun the fig 3 J&P example, not a hint of difference in results :(

[slayoo]

and Fig 1 (K et al. example) looks as follows:

at least, here there is some "response" to the changed constants

[slayoo]

k3 addressed in #538
Currently the plot looks well!

[trontrytel]

Sounds good. Now we only have to convince ourselves that the way we treat Henrys law is correct...

[slayoo]

:)

[trontrytel]

Very cool!

[slayoo]

the other two constants are now also changes in #538
Closing!