Cannot define one callback per request

[mjeanroy]

If you subscribe to multiple topics, you cannot define one callback per subscriptions : all callbacks are always called.
Since "jQuery.atmosphere.request" has a "callback" property, I thought it was possible but no, because "invokeCallback" function don't look at it.
I looked at jQuery plugin and I think you can fix it by adding to "invokeCallback" function :

if (typeof(jQuery.atmosphere.request.callback) == 'function') {
  jQuery.atmosphere.request.callback(response);
}

I tested, it seems to work, but maybe it's not the best way to do it.

[jfarcand]

I like it. Will add it now. Do you have a sample you can share so I can test?

[jfarcand]

So the new code will looks like

       invokeCallback: function(response) {
        var call = function (index, func) {
            func(response);
        };


        if (typeof(jQuery.atmosphere.request.callback) == 'function') {
            jQuery.atmosphere.request.callback(response);
        } else {
            jQuery.atmosphere.log(logLevel, ["Invoking " + jQuery.atmosphere.callbacks.length + " callbacks"]);
            if (jQuery.atmosphere.callbacks.length > 0) {
                jQuery.each(jQuery.atmosphere.callbacks, call);
            }
        }
    }

Is that OK?

[mjeanroy]

Yes, this is the idea.

But maybe, "jQuery.atmosphere.callbacks" schould be call even if "jQuery.atmosphere.request.callback" is defined.
With this, you can define one callback per request and "global" callbacks for all request. I don't know if it is the best choice, but I think it can be usefull to have "global" callbacks.

How I fixed it :

invokeCallback: function(response) {
    var call = function (index, func) {
        func(response);
    };

    // Invoke global callbacks
    jQuery.atmosphere.log(logLevel, ["Invoking " + jQuery.atmosphere.callbacks.length + " callbacks"]);
    if (jQuery.atmosphere.callbacks.length > 0) {
        jQuery.each(jQuery.atmosphere.callbacks, call);
    }
    // Invoke request callback
    if (typeof(jQuery.atmosphere.request.callback) == 'function') {
        jQuery.atmosphere.request.callback(response);
    }
}

I can write a sample you can test, where can I send it to you ?

[jfarcand]

Make a lot of sence. Use jfarcand@apache.org

Thanks a lot!

[jfarcand]

OK I've integrated it with a basic test. Still highly interested to a simple sample if you have a chance. Thanks a lot.

[mjeanroy]

I just sent you my sample at jfarcand@apache.org.
Thanks!

[jfarcand]

Works like a charm!!!

Thanks!